Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to NOT LIKE operator #29384

Merged
merged 9 commits into from
Jul 8, 2024
Merged

feat: add support to NOT LIKE operator #29384

merged 9 commits into from
Jul 8, 2024

Conversation

dacopan
Copy link
Contributor

@dacopan dacopan commented Jun 26, 2024

SUMMARY

Change get_sqla_query method of helpers.py to support NOT_LIKE operator

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (76d897e) to head (1cd177f).
Report is 418 commits behind head on master.

Files Patch % Lines
superset/models/helpers.py 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #29384      +/-   ##
==========================================
+ Coverage   60.48%   70.32%   +9.83%     
==========================================
  Files        1931     1967      +36     
  Lines       76236    78342    +2106     
  Branches     8568     8966     +398     
==========================================
+ Hits        46114    55095    +8981     
+ Misses      28017    21049    -6968     
- Partials     2105     2198      +93
Flag Coverage Δ
hive 49.04% <20.00%> (-0.12%) ⬇️
javascript 58.05% <ø> (+0.34%) ⬆️
mysql 76.99% <40.00%> (?)
postgres 77.10% <40.00%> (?)
presto 53.66% <20.00%> (-0.14%) ⬇️
python 83.69% <40.00%> (+20.20%) ⬆️
sqlite 76.57% <40.00%> (?)
unit 59.63% <20.00%> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/XS and removed size/M labels Jul 2, 2024
@dacopan dacopan requested a review from mistercrunch July 2, 2024 02:33
@rusackas
Copy link
Member

rusackas commented Jul 3, 2024

Running CI 🤞

@dacopan
Copy link
Contributor Author

dacopan commented Jul 3, 2024

I don't understand why fail front end test, my changes not affect to failed tests

@rusackas
Copy link
Member

rusackas commented Jul 3, 2024

Re-running that one... it might just be flaky, I've seen this one fail randomly before.

@dacopan
Copy link
Contributor Author

dacopan commented Jul 3, 2024

I no have option to re-run

@dacopan
Copy link
Contributor Author

dacopan commented Jul 7, 2024

@rusackas please your help with the pipeline, in my local server all test run OK, I don't understand why fail in test that files that not changed from master

@rusackas
Copy link
Member

rusackas commented Jul 8, 2024

Running it again... ping me if it flakes out :)

mistercrunch
mistercrunch approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit 9724c99 into apache:master Jul 8, 2024
37 checks passed
@dacopan dacopan deleted the feature/support-not-like branch July 8, 2024 19:26
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@dacopan @eschutho
feat: add support to NOT LIKE operator (#29384)
76d1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mistercrunch mistercrunch mistercrunch approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
packages size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dacopan @rusackas @mistercrunch